Implement dpnp.erf through pybind11 extension
#2551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_49 ran successfully. |
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2551/index.html |
… result, mismatching scipy
antonwolfy
force-pushed
the
add-erf-impl
branch
from
c261a83 to
410dcb5
Compare
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev,
vtavana and
ndgrigorian
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR changes the implementation of
dpnp.erffunction. It now invokesoneapi::mkl::vmimplementation from pybind11 extension of OneMKL VM if possible or uses dedicated kernel from pybind11 extension ofufunc.